Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-notification-list): improve keyboard accessibility for the "More" button #10822

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

TeodorTaushanov
Copy link
Member

@TeodorTaushanov TeodorTaushanov commented Feb 11, 2025

Improve keyboard accessibility for the More button according to the specification.

  • Single press of the 'Up Arrow' or 'Down Arrow' key shifts focus to the More button.
  • Single press of the 'Home' key shifts focus to the first notification within the group.
  • Single press of the 'End' key shifts focus to the last notification within the group. Double press of the 'End' key shifts focus to the More button within the group.

JIRA: BGSOFUIRODOPI-3215

@TeodorTaushanov TeodorTaushanov changed the title fix(ui5-notification-list): fix Load More button keyboard support fix(ui5-notification-list): improve keyboard accessibility for the "Load More" button Feb 13, 2025
@TeodorTaushanov TeodorTaushanov requested review from Stoev and a team February 17, 2025 07:59
Copy link

@Stoev Stoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider adding briefly what's included in the improvement (for example, which keys enable users to do smth).

Please double check whether the button's name corresponds to its name in the docu. At least in this sample, the button is called "More": https://sap.github.io/ui5-webcomponents/components/List/#growing-on-button-press

@TeodorTaushanov TeodorTaushanov changed the title fix(ui5-notification-list): improve keyboard accessibility for the "Load More" button fix(ui5-notification-list): improve keyboard accessibility for the "More" button Feb 17, 2025
@TeodorTaushanov
Copy link
Member Author

Please consider adding briefly what's included in the improvement (for example, which keys enable users to do smth).

Please double check whether the button's name corresponds to its name in the docu. At least in this sample, the button is called "More": https://sap.github.io/ui5-webcomponents/components/List/#growing-on-button-press

Done.

Copy link

@Stoev Stoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve keyboard accessibility for the More button according to the specification.

  • Single press of the 'Up Arrow' or 'Down Arrow' key shifts focus to the More button.
  • Single press of the 'Home' key shifts focus to the first notification within the group.
  • Single press of the 'End' key shifts focus to the last notification within the group. Double press of the 'End' key shifts focus to the More button within the group.

@TeodorTaushanov
Copy link
Member Author

Improve keyboard accessibility for the More button according to the specification.

  • Single press of the 'Up Arrow' or 'Down Arrow' key shifts focus to the More button.
  • Single press of the 'Home' key shifts focus to the first notification within the group.
  • Single press of the 'End' key shifts focus to the last notification within the group. Double press of the 'End' key shifts focus to the More button within the group.

Done

Copy link

@Stoev Stoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants