-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui5-notification-list): improve keyboard accessibility for the "More" button #10822
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider adding briefly what's included in the improvement (for example, which keys enable users to do smth).
Please double check whether the button's name corresponds to its name in the docu. At least in this sample, the button is called "More": https://sap.github.io/ui5-webcomponents/components/List/#growing-on-button-press
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improve keyboard accessibility for the More button according to the specification.
- Single press of the 'Up Arrow' or 'Down Arrow' key shifts focus to the More button.
- Single press of the 'Home' key shifts focus to the first notification within the group.
- Single press of the 'End' key shifts focus to the last notification within the group. Double press of the 'End' key shifts focus to the More button within the group.
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Improve keyboard accessibility for the More button according to the specification.
JIRA: BGSOFUIRODOPI-3215