Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: create and connect all main components to test jsdom support #10812

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

pskelin
Copy link
Contributor

@pskelin pskelin commented Feb 10, 2025

Basic jsdom support was added with #10606

Later, a bug was found in the ui5-button which was using some non-existent functionality (fixed with #10782)

This change adds a smoke test that will run for all components from the main package by doing the following for each registered tag in the bundle:

// step 1 - it should be possible to create every element
const el = document.createElement(tag);
// step 2 - adding it in the document should not fail (connectedCallback and render)
document.body.appendChild(el)

@pskelin pskelin requested a review from ilhan007 February 10, 2025 13:11
@ilhan007 ilhan007 merged commit 8fcc5fe into main Feb 11, 2025
10 of 12 checks passed
@ilhan007 ilhan007 changed the title chore: create and connect all main components to test jsdom support test: create and connect all main components to test jsdom support Feb 11, 2025
@ilhan007 ilhan007 deleted the jsdom-more-test branch February 11, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants