fix(ui5-time-picker): display value state message in popover's header correctly on mobile #10795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… correctly on mobile
vladitasev
requested changes
Feb 10, 2025
vladitasev
approved these changes
Feb 12, 2025
|
🎉 This PR is included in version v2.8.0-rc.1 🎉 The release is available on v2.8.0-rc.1 Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We encountered an issue on mobile devices where opening the
ui5-time-picker's time selection popover by clicking the input field (instead of the icon) results in an empty value state message in the header.The reason behind this was that there was a racing condition between the ResponsivePopover and the Popover in the template, where the first one, 'steals' the
slot=valueStateMessage.The first component to access the valueStateMessage slot claims it, and since a given light DOM node can only be assigned to one slot at a time, the other component ends up without the value state message.
Before
After