Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui5-time-picker): Improve component based on user testing #10577

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat(ui5-time-picker): Improve component based on user testing #10577

wants to merge 5 commits into from
+388 −316

Conversation

NHristov-sap
Copy link
Contributor

There was user testing that gave some directions what to improve in <ui5-time-picker> component.

The following points are covered with this PR:

  • improved 24 hrs clock dial
  • clickable dots in "minutes" and "seconds" view
  • hover over the dots result in displayed hover number
  • animation - speed up animation

@NHristov-sap NHristov-sap requested a review from hinzzx January 20, 2025 09:22
hinzzx
hinzzx requested changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@hinzzx hinzzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add tests ?

packages/main/src/TimePickerClock.ts Outdated Show resolved Hide resolved
packages/main/src/themes/TimePickerClock.css Outdated Show resolved Hide resolved
packages/main/src/TimeSelectionClocks.ts Outdated Show resolved Hide resolved
packages/main/src/TimeSelectionClocks.ts Show resolved Hide resolved
packages/main/src/themes/TimePickerClock.css Outdated Show resolved Hide resolved
packages/main/src/TimePickerClockTemplate.tsx Show resolved Hide resolved
vladitasev
vladitasev requested changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@vladitasev vladitasev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The animation runs when opening the popup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hinzzx hinzzx Awaiting requested review from hinzzx

@vladitasev vladitasev Awaiting requested review from vladitasev

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NHristov-sap @vladitasev @hinzzx