fix(ui5-combobox): fire selection-change event when typed word fully matches an item #10524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…matches item Fixes #10239 When combobox is in noTypeahead mode, if the user writes a text that matches exactly a list item, selection-change event was not fired if the user selects the item by clicking on it. Now the selection0change event fires when item text is exactly typed and immediately selected from the items list.
…matches item Fixes #10239 When combobox is in noTypeahead mode, if the user writes a text that matches exactly a list item, selection-change event was not fired if the user selects the item by clicking on it. Now the selection0change event fires when item text is exactly typed and immediately selected from the items list.
…omponents into cb-selection-change
ivoplashkov
reviewed
Jan 23, 2025
| @@ -1118,15 +1118,16 @@ class ComboBox extends UI5Element implements IFormInputElement { | |||
|
|
|||
| const sameItemSelected = this.value === this._selectedItemText; | |||
| const sameSelectionPerformed = this.value.toLowerCase() === this.filterValue.toLowerCase(); | |||
| const shouldFireSelectionEvent = this.noTypeahead && this._lastValue !== this.value; | |||
There was a problem hiding this comment.
I am not sure if this check is correct. There is a case where we select an item from the picker and then delete last character from the value and select the same item again. Since the typeahead is off, no selection has been performed during the value change therefore I believe the event should be fired just once, but now it's fired twice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10239
When combobox is in noTypeahead mode, if the user writes a text that matches exactly a list item, selection-change event was not fired if the user selects the item by clicking on it.
Now the selection-change event fires when item text is exactly typed and immediately selected from the items list.