feat(ui5-multicombobox): introduce open property and openChange event #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Nia Peeva seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
ilhan007
changed the title
ilhan007
reviewed
Nov 15, 2019
packages/main/src/MultiComboBox.js
Outdated
| */ | ||
| opened: { | ||
| type: Boolean, | ||
| defaultValue: false, |
There was a problem hiding this comment.
For Boolean properties, we don't write the defaultValue, because it is always false (can't be never true). It's good to have it in the jsdoc, so @defaultvalue false is correct, just remove defaultValue: false from the "opened" object in the metadata.
There was a problem hiding this comment.
Thanks! I will remove it.
ilhan007
reviewed
Nov 15, 2019
| resetBtn.click(); | ||
| icon.click(); | ||
| assert.ok(mcb.getProperty("opened"), "MultiComboBox should be opened"); | ||
| assert.strictEqual(eventInput.getValue(), "openedChange", "selectionChange should be called"); |
There was a problem hiding this comment.
did you meant "openedChange should be called" here and below
ilhan007
changed the title
ilhan007
approved these changes
Nov 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIXES: #713