Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MultiComboBox] Add selectionFinish event #713

Closed
vbersch opened this issue Aug 2, 2019 · 2 comments · Fixed by #930
Closed

[MultiComboBox] Add selectionFinish event #713

vbersch opened this issue Aug 2, 2019 · 2 comments · Fixed by #930
Assignees

Comments

@vbersch
Copy link
Contributor

vbersch commented Aug 2, 2019

Describe the solution you'd like
So far the MultiComboBox has the selectionChange event, which fires as soon as you select an item.
It would be great to have an event which only fires after the selection is complete (the Modal containing the selectionItems loses focus)

The event should contain all items that were added/removed as well as all selected items.

@MapTo0
Copy link
Member

MapTo0 commented Aug 16, 2019

Hey @vbersch

SelectionFinish sounds strange to me as the selection is actually never finished for the end user - you can always change it no matter if the Popover is open or no.

in OpenUI5 we have similar functionality - an event fired after the picker (popover) is closed, would this be enough for you? afterPickerClose or something like that.

@vbersch
Copy link
Contributor Author

vbersch commented Aug 16, 2019

Hi Martin,

Yes, thats exactly the event I meant. I don´t have preferences on how to call it.
It´s called selectionFinish in ui5 though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants