-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Topic P][Feature Request]: New focus handling behaviour #8320
Comments
Related to: #8250 |
This was referenced Mar 26, 2024
kgogov
added a commit
that referenced
this issue
Apr 8, 2024
Adjusted ui5-checkbox focus display rules. On desktop, focus outline is always visible. For mobile, focus outline only appears with an external keyboard, it remains hidden for touch focus. Related to: #8320
kgogov
added a commit
that referenced
this issue
Apr 15, 2024
Adjusted ui5-avatar-group focus display rules. On desktop, focus outline is always visible. For mobile, focus outline only appears with an external keyboard, it remains hidden for touch focus. Related to: #8320
kgogov
added a commit
that referenced
this issue
Apr 16, 2024
Adjusted `ui5-icon` focus display rules. On desktop, focus outline is always visible. For mobile, focus outline only appears with an external keyboard, it remains hidden for touch focus. Related to: #8320
Internal Reference: BGSOFUIPIRIN-6469 |
This was referenced Apr 22, 2024
kgogov
added a commit
that referenced
this issue
Apr 23, 2024
Adjusted `ui5-media-gallery` focus display rules. On desktop, focus outline is always visible. For mobile, focus outline only appears with an external keyboard, it remains hidden for touch focus. Related to: #8320
kgogov
added a commit
that referenced
this issue
Apr 24, 2024
Adjusted `ui5-shellbar` focus display rules. On desktop, focus outline is always visible. For mobile, focus outline only appears with an external keyboard, it remains hidden for touch focus. Related to: #8320
kgogov
added a commit
that referenced
this issue
May 10, 2024
Adjusted `ui5-product-switch-item` focus display rules. On desktop, focus outline is always visible. For mobile, focus outline only appears with an external keyboard, it remains hidden for touch focus. Related to: #8320
1 task
kgogov
added a commit
that referenced
this issue
May 29, 2024
Adjusted ui5-list and other derivatives list items focus display rules. On desktop, focus outline is always visible. For mobile, focus outline only appears with an external keyboard, it remains hidden for touch focus. Related to: #8320, #7858 --------- Co-authored-by: Teodor Taushanov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Feature Request Description
According to the latest visual and interaction designs, the focus should behave like this:
Input elements remain unchanged - they always show focus as additional attention is needed.
To be clarified:
Example implementation
#8253
Proposed Solution
A pure CSS solution is possible by using
:focus-visible
which will match only when focus is received via keyboard. This is sufficient for mobile.For desktop, the
:focus
selector should be used with an additional attribute on the host manually set by the component.Use
:focus-within
if a nested component can receive focus, such as a button with avatar, the avatar will get the focus when touched.The manual attributes
[focused]
and setting them viafocusin
andfocusout
handlers is discouraged and should be clarified additionally.Proposed Alternatives
No response
Organization
UI5
Additional Context
No response
Priority
None
Privacy Policy
The text was updated successfully, but these errors were encountered: