Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui5-wizard: Navigation area color not affected by theme #2877

Closed
todormikov opened this issue Feb 26, 2021 · 1 comment · Fixed by #2892
Closed

ui5-wizard: Navigation area color not affected by theme #2877

todormikov opened this issue Feb 26, 2021 · 1 comment · Fixed by #2892
Assignees
@ilhan007
Labels
bug This issue is a bug in the code Medium Prio TOPIC RL

Comments

@todormikov
Copy link

Describe the bug
The color of the navigation area does not change with themes. It is always white.

To reproduce
Steps to reproduce the behavior:

  1. Go to https://sap.github.io/ui5-webcomponents/playground/components/Wizard/
  2. Change the theme to Quartz Dark from the cogwheel button on the right of the page
  3. The color of the navigation area on the sample wizard remains white

Isolated example
https://sap.github.io/ui5-webcomponents/playground/components/Wizard/

Expected behavior
When the overall theme is changed, the color of the navigation area should change accordingly.

Screenshots
image

Context

  • UI5 Web Components version: v1.0.0-rc.12 version

Affected components
Wizard
@TeodorTaushanov TeodorTaushanov added bug This issue is a bug in the code Medium Prio TOPIC RL labels Feb 26, 2021
@TeodorTaushanov
Copy link
Member

Hello @SAP/ui5-webcomponents-topic-rl, can you check this issue?

@ilhan007 ilhan007 mentioned this issue Mar 1, 2021
Merged
@ilhan007 ilhan007 self-assigned this Mar 1, 2021
ilhan007 added a commit that referenced this issue Mar 2, 2021
@ilhan007
fix(ui5-wizard): use CSS vars for navigation bg-color (#2892)
c967c6c 
We introduced a small degradation with the following [PR](#2590), using a fixed color, instead of CSS var. Now, the Wizard navigation looks fine in all themes:

FIXES: #2877
ilhan007 added a commit that referenced this issue Mar 17, 2021
@ilhan007
fix(ui5-wizard): use CSS vars for navigation bg-color (#2892)
03383c3 
We introduced a small degradation with the following [PR](#2590), using a fixed color, instead of CSS var. Now, the Wizard navigation looks fine in all themes:

FIXES: #2877
ilhan007 added a commit that referenced this issue Mar 18, 2021
@ilhan007
fix(ui5-wizard): use CSS vars for navigation bg-color (#2892)
7352eb0 
We introduced a small degradation with the following [PR](#2590), using a fixed color, instead of CSS var. Now, the Wizard navigation looks fine in all themes:

FIXES: #2877
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilhan007 ilhan007

Labels
bug This issue is a bug in the code Medium Prio TOPIC RL
Projects
Maintenance - Topic RL
Status: Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-wizard): use CSS vars for navigation bg-color SAP/ui5-webcomponents
3 participants
@TeodorTaushanov @ilhan007 @todormikov