Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui5-tabcontainer: overflow menu button has no title #2607

Closed
elenastoyanovaa opened this issue Dec 21, 2020 · 0 comments · Fixed by #2639
Closed

ui5-tabcontainer: overflow menu button has no title #2607

elenastoyanovaa opened this issue Dec 21, 2020 · 0 comments · Fixed by #2639
Assignees
@GerganaKremenska
Labels
ACC bug This issue is a bug in the code Medium Prio TOPIC RD

Comments

@elenastoyanovaa
Copy link
Contributor

Hello @SAP/ui5-webcomponents-topic-rd ,

Could you check this issue?

Describe the bug
The overflow menu icon-only button has no title set.

To reproduce
Steps to reproduce the behavior:

  1. Go to https://sap.github.io/ui5-webcomponents/master/playground/components/TabContainer/
  2. Inspect the DOM of the native button representing the overflow menu

Expected behavior
A title="Overflow Menu" should be set to this element since it is an icon only button. After implementation please update the Accessibility Status Wiki of the ui5-tabcontainer web component.

Affected components
ui5-tabcontainer
@elenastoyanovaa elenastoyanovaa added the bug This issue is a bug in the code label Dec 21, 2020
@GerganaKremenska GerganaKremenska self-assigned this Jan 7, 2021
@GerganaKremenska GerganaKremenska mentioned this issue Jan 7, 2021
Merged
@GerganaKremenska GerganaKremenska linked a pull request Jan 7, 2021 that will close this issue
fix(ui5-tabcontainer): overflow menu button is added a title #2639
Merged
ilhan007 pushed a commit that referenced this issue Jan 8, 2021
fix(ui5-tabcontainer): overflow menu button is added a title (#2639)
943e4ce 
Fixes: #2607
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GerganaKremenska GerganaKremenska

Labels
ACC bug This issue is a bug in the code Medium Prio TOPIC RD
Projects
Maintenance - Topic RD
Status: Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-tabcontainer): overflow menu button is added a title GerganaKremenska/ui5-webcomponents
2 participants
@elenastoyanovaa @GerganaKremenska