Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-avatar): fix XS size #2582

Merged
merged 3 commits into from
Dec 17, 2020
Merged

fix(ui5-avatar): fix XS size #2582

merged 3 commits into from
Dec 17, 2020

Conversation

ilhan007
Copy link
Member

@ilhan007 ilhan007 commented Dec 16, 2020

With the introduce of the AvatarGroup the XS size of the Avatar has been broken. Due to the following css the XS size appeared 3rem X 3rem, instead of 2rem X 2rem (as it is by spec). The "XS" styles define min-height and min-width, but the default styles make it 3rem by 3rem.

:host {
	height: 3rem;
	width: 3rem;
}
:host([_size="XS"]),
:host([size="XS"]) {
	min-height: 2rem;
	min-width: 2rem;
	font-size: .75rem;
}

nnaydenow
nnaydenow previously approved these changes Dec 16, 2020
Copy link
Contributor

@nnaydenow nnaydenow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: we could add sample with avatar-size="S" just for test purpose.

@ilhan007
Copy link
Member Author

Minor: we could add sample with avatar-size="S" just for test purpose.

added more samples

Copy link
Contributor

@dobrinyonkov dobrinyonkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ilhan007 ilhan007 merged commit 9661ab8 into master Dec 17, 2020
@ilhan007 ilhan007 deleted the fix-avatar-xs branch December 17, 2020 07:52
niyap pushed a commit to niyap/ui5-webcomponents that referenced this pull request Dec 17, 2020
With the introduce of the AvatarGroup the XS size of the Avatar has been broken. Due to the following css the XS size appeared 3rem X 3rem, instead of 2rem X 2rem (as it is by spec). The "XS" styles define min-height and min-width, but the default styles make it 3rem by 3rem.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants