Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui5-date-picker: Text color contrast issues in High contrast black on white theme #2372

Closed
GongRichard opened this issue Oct 20, 2020 · 1 comment · Fixed by #2378
Closed

Comments

@GongRichard
Copy link

Describe the bug
Text color contrast issues in High contrast black on white theme.

To reproduce
Steps to reproduce the behavior:

  1. Go to https://github.wdf.sap.corp/pages/xweb/goalmanagementx/app.html?mock&sap-ui-theme=sap_belize_hcb#/goal-list
  2. click 'Skip Tour' button
  3. click more actions button on the top right of Goal Card
  4. click 'Create Activity' button
  5. select a new satus 'low'
  6. open date picker for 'Achieved On'

Actual Results
The visual pink color ((#e269C9)) outline around the current date fails to meet 7:1 against the grey color background (#171717) and (#2E2E2E) of calendar widget.

Expected behavior
In high contrast themes, visual selected outline should meet 7:1 against their backgrounds. Hence modify the colors to meet this contrast ratio

Screenshots
HCM - date pink outline issue
HCM - date pink outline issue against greyish shade

Context

  • UI5 Web Components version:0.23.2
  • OS/Platform: {...}
  • Browser (if relevant): {...}
  • Other information: {...}
@ilhan007
Copy link
Member

FYI @SAP/ui5-webcomponents-topic-b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants