Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panel does not display if DatePicker is not imported (React) #237

Closed
akhnot opened this issue Mar 22, 2019 · 2 comments
Closed

Panel does not display if DatePicker is not imported (React) #237

akhnot opened this issue Mar 22, 2019 · 2 comments
Assignees

Comments

@akhnot
Copy link

akhnot commented Mar 22, 2019

Describe the bug
In my React application Panel would not display until I imported the DatePicker even though
no DatePicker was displayed

Please find stacktrace below.

To reproduce

  1. clone react example project https://github.com/SAP/ui5-webcomponents-sample-react
  2. in the App.js remove the DatePicker reference so as the DatePicker import
  3. Yarn start => the Panel won't show
  4. Import back the DatePicker => the Panel shows up

Expected behavior
Panel should display even without importing the DatePicker

Screenshots
If applicable, add screenshots to help explain your problem.

Context

  • UI5 Web Components version 9
  • OS/Platform: MAcOs
  • Browser (if relevant): Chrome
  • Other information: {...}

Affected components (if known)

Log output / Any errors in the console
Uncaught TypeError: ui_thirdparty_jquery__WEBPACK_IMPORTED_MODULE_0_.default.extend is not a function
at Object.push../node_modules/@ui5/webcomponents-core/dist/sap/base/util/LoaderExtensions.js.LoaderExtensions.loadResource (LoaderExtensions.js:56)
at Function.push../node_modules/@ui5/webcomponents-core/dist/sap/base/util/Properties.js.Properties.create (Properties.js:154)
at tryToLoadNextProperties (ResourceBundle.js:282)
at loadNextPropertiesSync (ResourceBundle.js:244)
at new ResourceBundle (ResourceBundle.js:126)
at Function.push../node_modules/@ui5/webcomponents-core/dist/sap/base/i18n/ResourceBundle.js.ResourceBundle.create (ResourceBundle.js:310)
at getResourceBundle (ResourceBundle.js:113)
at new Panel (Panel.js:225)
at Function.define (WebComponent.js:589)
at Function._callee$ (Panel.js:306)
at tryCatch (runtime.js:63)
at Generator.invoke [as _invoke] (runtime.js:282)
at Generator.prototype.(:3001/anonymous function) [as next] (http://localhost:3001/static/js/1.chunk.js:52949:21)
at asyncGeneratorStep (asyncToGenerator.js:3)
at _next (asyncToGenerator.js:25)

@MapTo0
Copy link
Member

MapTo0 commented Mar 22, 2019

Hi @akhnot ,

Unfortunately we missed a dependency in the last release of the Panel.

As a workaround I would suggest you to import:

import "@ui5/webcomponents-base/src/sap/ui/webcomponents/base/shims/jquery-shim";

* before Panel's import

We will address this issue in the next release

@MapTo0
Copy link
Member

MapTo0 commented Mar 27, 2019

Hello @akhnot ,

A fix will be available in the next npm release.

Regards!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants