Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility issue with ui5-checkbox as the shadow DOM input element with type=checkbox is missing aria-label attribute #2265

Closed
rajatmtalwar opened this issue Sep 28, 2020 · 1 comment · Fixed by #2272
Closed

Accessibility issue with ui5-checkbox as the shadow DOM input element with type=checkbox is missing aria-label attribute #2265

rajatmtalwar opened this issue Sep 28, 2020 · 1 comment · Fixed by #2272
Assignees
@fifoosid
Labels
ACC High Prio SAP SF SF_ACC
Milestone
0.23.6

Comments

@rajatmtalwar
Copy link

Describe the bug
Accessibility issue with ui5-checkbox as the shadow DOM input element with type=checkbox is missing aria-label attribute
Axe identifies this as a problem
image

To reproduce
Steps to reproduce the behavior:
Goto https://sap.github.io/ui5-webcomponents/playground/components/CheckBox/
check the shadow dom for any of the checkboxes

Expected behavior
ui5-checkbox label value should be associated to the shadow input dom element with type "checkbox"

Screenshots
image

Affected components (if known)
ui5-checkbox
@vladitasev
Copy link
Contributor

I think we should have the same solution as for ui5-button.

@fifoosid fifoosid self-assigned this Sep 29, 2020
@fifoosid fifoosid mentioned this issue Sep 30, 2020
Merged
@ilhan007 ilhan007 added this to the 0.23.4 milestone Sep 30, 2020
@ilhan007 ilhan007 modified the milestones: 0.23.4, 0.23.5 Oct 6, 2020
@ilhan007 ilhan007 modified the milestones: 0.23.5, 0.23.6 Oct 8, 2020
@fifoosid fifoosid mentioned this issue Jun 21, 2021
Merged
ilhan007 pushed a commit that referenced this issue Jul 30, 2021
@fifoosid
feat: implement assessibleNameRef for many components (#3442)
42d3ed5 
Part of #3107 

BREAKING CHANGE: The support for ```aria-labelledby``` have been deprecated in favour of  new attribute ```accessible-name-ref``` for the following components:
- ComboBox (Requested by SF #1916)
- DatePicker (Requested by SF #2107)
- Input (Requested #1866)
- List (Requested by SF #1886)
- Rating Indicator
- Select (Requested by SF #2107)
- StepInput (Implemented as part of the initial implementation #2804)
- TextArea (Requested by SF #2107)
- WizardStep (Implemented as part of the initial implementation #2400)
The ```aria-labelledby``` has been deprecated for the following component:
- Button (Requested by SF #1425)
The ```accessible-name``` has been deprecated for the following components:
- Link (Requested by SF #2356)
 Both ```aria-labelledby``` and ```accessible-name``` have been deprecated for the following components:
- Card (Requested by CBC #2127)
- CheckBox (Requested by SF #2265)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fifoosid fifoosid

Labels
ACC High Prio SAP SF SF_ACC
Projects
None yet
Milestone
0.23.6
Development

Successfully merging a pull request may close this issue.

feat(ui5-checkbox): implement ariaLabelledby property SAP/ui5-webcomponents
5 participants
@rajatmtalwar @ilhan007 @vladitasev @fifoosid @nikolay-kolarov