Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature request] webcomponents-tools support to compile the template .hbs files in sub-directories #2065

Closed
alex-zhang opened this issue Aug 5, 2020 · 0 comments · Fixed by #2067
Closed

[Feature request] webcomponents-tools support to compile the template .hbs files in sub-directories #2065

alex-zhang opened this issue Aug 5, 2020 · 0 comments · Fixed by #2067
Assignees
@ilhan007
Labels
SAP SF
Milestone
1.0.0-rc.9

Comments

@alex-zhang
Copy link

hi,

we current now use the webcomponents-tools for this repo https://github.wdf.sap.corp/xweb/common-webcomponents.

so we now put the web-components in the src directory. below.

image

but some web-component is very complex, we want use the directory to organize the sub files, maybe like below:

|- src
|---- PersonQuickcard
|--------------------- PersonQuickcard.js
|--------------------- PersonQuickcard.hbs
|--------------------- PersonQuickcard.test.js
|
|----------------------PersonQuickcardAddBadge
|-------------------------------------------------PersonQuickcardAddBadge.js
|-------------------------------------------------PersonQuickcardAddBadge.test.js
|-------------------------------------------------PersonQuickcardAddBadge.hbs
....

so i think the ${LIB}/hbs2ui5/index.js should deep walk-through the target directory.
@ilhan007 ilhan007 added the SAP SF label Aug 5, 2020
@ilhan007 ilhan007 self-assigned this Aug 5, 2020
@ilhan007 ilhan007 mentioned this issue Aug 5, 2020
Merged
ilhan007 added a commit that referenced this issue Aug 10, 2020
@ilhan007
feat(tools): process HBS files in nested directories (#2067)
13f1d2a 
Now the the tools will process HBS files within nested directories and produce the output "lit" files into the "dist",
maintaining the file structures.

FIXES #2065
ilhan007 added a commit that referenced this issue Aug 10, 2020
@ilhan007
feat(tools): process HBS files in nested directories (#2067)
94b6dcf 
Now the the tools will process HBS files within nested directories and produce the output "lit" files into the "dist",
maintaining the file structures.

FIXES #2065
@ilhan007 ilhan007 added this to the 1.0.0-rc.9 milestone Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilhan007 ilhan007

Labels
SAP SF
Projects
None yet
Milestone
1.0.0-rc.9
Development

Successfully merging a pull request may close this issue.

feat(tools): process HBS files in nested directories SAP/ui5-webcomponents
2 participants
@alex-zhang @ilhan007