Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenUI5/SAPUI5 CSS Variables detection is not working anymore for OpenUI5/SAPUI5 1.79+ #1932

Closed
petermuessig opened this issue Jul 8, 2020 · 0 comments · Fixed by #1933
Closed

OpenUI5/SAPUI5 CSS Variables detection is not working anymore for OpenUI5/SAPUI5 1.79+ #1932

petermuessig opened this issue Jul 8, 2020 · 0 comments · Fixed by #1933
Assignees
@ilhan007

Comments

@petermuessig
Copy link
Contributor

Describe the bug
The CSS variables detection in the OpenUI5Support assumes that the css variables file is names css-variables.css:
https://github.com/SAP/ui5-webcomponents/blob/master/packages/base/src/features/OpenUI5Support.js#L68-L79

With OpenUI5/SAPUI5 1.79 we had to adopt the name of the file to css_variables.css and the check should be adopted check for css_variables.css starting with 1.79.

To reproduce
Steps to reproduce the behavior:

  1. Run the kitchen.openui5 on OpenUI5/SAPUI5 1.79

Isolated example
Not needed - if so, please let me know.

Expected behavior
CSS Variables should be detected properly!

Context

  • UI5 Web Components version: latest
  • OS/Platform: any
  • Browser (if relevant): any
  • Other information: OpenUI5/SAPUI5 1.79

Affected components (if known)
OpenUI5Support
@ilhan007 ilhan007 self-assigned this Jul 9, 2020
@ilhan007 ilhan007 mentioned this issue Jul 9, 2020
Merged
ilhan007 added a commit that referenced this issue Jul 9, 2020
@ilhan007
fix(framework): Fix openui5 css varaibles detection (#1933)
bb5b724 
Change the regex to detect the openui5 CSS variables properly as from 1.79 the CSS Variables filename has changed to css_variables.css (previously css-varaibles.css with dash).
But, the script will match the old name with "-" dash as well, if we need to support it, otherwise we can leave "_" only to support the latest name.

FIXES: #1932
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilhan007 ilhan007

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(framework): Fix openui5 css varaibles detection SAP/ui5-webcomponents
2 participants
@petermuessig @ilhan007