Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List navigation handling is broken #192

Closed
fifoosid opened this issue Mar 15, 2019 · 0 comments
Closed

List navigation handling is broken #192

fifoosid opened this issue Mar 15, 2019 · 0 comments
Assignees
@ilhan007

Comments

@fifoosid
Copy link
Contributor

Describe the bug
A clear and concise description of what the bug is.

Pressing Shift + Tab on List Item is throwing an error in the console.

To reproduce
Steps to reproduce the behavior:

  1. Go to https://sap.github.io/ui5-webcomponents/playground/components/List/
  2. Focus any List Item
  3. Tab Shift + Tab
  4. Check your console.

Expected behavior
A clear and concise description of what you expected to happen.

No error is thrown.

Screenshots
If applicable, add screenshots to help explain your problem.

image

Context

  • UI5 Web Components version: 0.8.0
  • OS/Platform: {MAC}
  • Browser (if relevant): {Chrome}

Affected components (if known)
ListItemBase

Log output / Any errors in the console

In the screenshot
@ilhan007 ilhan007 self-assigned this Mar 15, 2019
ilhan007 added a commit that referenced this issue Mar 15, 2019
@ilhan007
fix(ui5-list): enable backward navigation with SHIFT+TAB
73ec32c 
After major refactoring of the PseudoEvents onsaptabprevious has stopped working.
Furthermore, the _handleTabPrevious method did not exist.
FIXES: #192
@ilhan007 ilhan007 mentioned this issue Mar 15, 2019
Merged
ilhan007 added a commit that referenced this issue Mar 15, 2019
@ilhan007
fix(ui5-list): correct backward navigation with SHIFT+TAB (#193)
037409d 
After the refactoring of the Pseudo events onsaptabprevious stopped working.
It`s now replaced by _handleTabPrevious.
FIXES: #192
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilhan007 ilhan007

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ilhan007 @fifoosid