Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui5-popover will move 1px after first time open up #1755

Closed
GongRichard opened this issue Jun 9, 2020 · 7 comments · Fixed by #2679
Closed

ui5-popover will move 1px after first time open up #1755

GongRichard opened this issue Jun 9, 2020 · 7 comments · Fixed by #2679
Assignees
Labels
bug This issue is a bug in the code High Prio SAP SF TOPIC RD

Comments

@GongRichard
Copy link

Hi colleague,
I am from SAP SuccessFactors team. Please help to take a look at this issue.

Describe the bug
In compact mode, some Status Drop Down popover and Action popover will move about 1px after the first time open up.
This issue can only be reproduced in compact mode.

To reproduce
Steps to reproduce the behavior:

  1. Go to GoalCardContainer
  2. Click More Actions button on the top right of Card
  3. Click Status Drop Down button on the bottom left of Card

Isolated example
PopoverMove

Expected behavior
Popover shouldn't move after open up.

Context

  • UI5 Web Components version: 1.0.0-rc7
  • OS/Platform: {macos}
  • Browser (if relevant): {Chrome/Edge}
  • Other information: {...}
@vladitasev vladitasev self-assigned this Jun 12, 2020
@vladitasev
Copy link
Contributor

vladitasev commented Jun 12, 2020

Hello @GongRichard ,

I was unable to reproduce the issue with our latest version on our test pages.
I notice you're using an old version: RC7
https://github.wdf.sap.corp/xweb/goalmanagementx/blob/master/package.json

Maybe that's the problem? There is a much newer version, maintained specifically for SFSF
0.21.1 (soon we'll release 0.21.2).

Could you try migrating to:
"@ui5/webcomponents": "0.21"

Regards,
Vladi

@GongRichard
Copy link
Author

Hi @vladitasev ,

Yes, I have tried 0.21 in my local. This issue can't be reproduced. I am closing this ticket.

Thanks,
Richard

@GongRichard
Copy link
Author

Hi @vladitasev ,

This issue shows again, we use wc version 0.21.10.
You can check page https://github.wdf.sap.corp/pages/xweb/goalmanagementx/app.html?mock&sap-ui-content-density=compact#/goal-list?templateType=tgm&templateId=22 to reproduce.

Thanks,
Richard

@ilhan007 ilhan007 added bug This issue is a bug in the code Medium Prio labels Aug 14, 2020
@GongRichard
Copy link
Author

Hi @ilhan007 and @vladitasev,

Would you please take a look at this issue first as we need to release our product next week?

Thanks,
Richard

@ilhan007
Copy link
Member

ilhan007 commented Jan 4, 2021

Hello @GongRichard is it still reproducible with 0.27.3? Should we use the same URL to check the issue:
https://github.wdf.sap.corp/pages/xweb/goalmanagementx/app.html?mock&sap-ui-content-density=compact#/goal-list?templateType=tgm&templateId=22

Does it use the latest SFSF version?

@GongRichard
Copy link
Author

Hi @ilhan007,

This issue still is reproducible with 0.27.3, you can use the same URL to check the issue.
https://github.wdf.sap.corp/pages/xweb/goalmanagementx/app.html?mock&sap-ui-content-density=compact#/goal-list?templateType=tgm&templateId=22
The version of that page is 0.27.3.

Thanks,
Richard

@ilhan007
Copy link
Member

ilhan007 commented Jan 5, 2021

Hello @SAP/ui5-webcomponents-topic-rd please have a look into this issue.

BR,
ilhan

@alexandar-mitsev alexandar-mitsev self-assigned this Jan 11, 2021
alexandar-mitsev added a commit to alexandar-mitsev/ui5-webcomponents that referenced this issue Jan 13, 2021
Now when a popover is dynamically created it is shown only after its size can be determined.
This prevents its position to flicker on opening.

Fixes: SAP#1755
alexandar-mitsev added a commit to alexandar-mitsev/ui5-webcomponents that referenced this issue Feb 2, 2021
Now when a popover is dynamically created it is shown only after its size can be determined.
This prevents its position to flicker on opening.

Fixes: SAP#1755
pskelin pushed a commit that referenced this issue Feb 8, 2021
…#2679)

Now when a popover is dynamically created it is shown only after its size can be determined.
This prevents its position to flicker on opening.

Fixes: #1755
ilhan007 pushed a commit that referenced this issue Feb 8, 2021
…#2679)

Now when a popover is dynamically created it is shown only after its size can be determined.
This prevents its position to flicker on opening.

Fixes: #1755
NHristov-sap pushed a commit to NHristov-sap/ui5-webcomponents that referenced this issue Feb 9, 2021
…SAP#2679)

Now when a popover is dynamically created it is shown only after its size can be determined.
This prevents its position to flicker on opening.

Fixes: SAP#1755
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code High Prio SAP SF TOPIC RD
Projects
Status: Completed
4 participants