Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui5-textarea: ValueState and ValueStateMessage support in TextArea component #1401

Closed
zhangliangyi opened this issue Mar 31, 2020 · 0 comments · Fixed by #1419 or #1411
Closed

ui5-textarea: ValueState and ValueStateMessage support in TextArea component #1401

zhangliangyi opened this issue Mar 31, 2020 · 0 comments · Fixed by #1419 or #1411
Assignees
@ilhan007

Comments

@zhangliangyi
Copy link

zhangliangyi commented Mar 31, 2020 •
edited
Loading

Hi,

Here is a feature request.

I am working on a form with ui5-wc but I found the TexArea component does not have the valueState property and valueStateMessage slot just like the Input.

So maybe it is reasonable to add the valueState and valueStateMessage in TextArea to make all fields have the consistent behavior.
@zhangliangyi zhangliangyi changed the title ValueState and ValueStateMessage support in TextArea component ui5-textarea: ValueState and ValueStateMessage support in TextArea component Apr 2, 2020
@ilhan007 ilhan007 self-assigned this Apr 2, 2020
This was referenced Apr 2, 2020
Closed
Merged
Merged
ilhan007 added a commit that referenced this issue Apr 3, 2020
@ilhan007
feat(ui5-textarea): add "valueStateMessage" slot (#1419)
d323d51 
- add "valueStateMessage" slot
- rename "valueStateMessage" CSS classes from "ui5-input-valuestatemessage-success" to "ui5-valuestatemessage--success", because they should not belong to the input only and ad two dashes to show modification (by the BEM notation)
- there is code duplication at places with the code that handles the valueStateMessage in Input, 
but also differences related to the fact that the TextArea has no suggestions and has this "exceeding" (like Warning) state.

FIXES: #1401
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilhan007 ilhan007

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@zhangliangyi @ilhan007