-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui5-tabcontainer): add tabLayout property #1214
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a whole I like the solution, but I was wondering whether it is a better idea to set the tab-layout property on ui5-tabcontainer, because an app would like all the tabs in a single tab container to have the same layout.
I was thinking the same, actually I was about to bring this for a discussion, but now I think it will be easier for user to set it once, moreover it's not by Fiori to have mixed layouts |
Fixes: #1195