Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab container: support tab label with count #1195

Closed
sunnyyadav100 opened this issue Feb 8, 2020 · 3 comments · Fixed by #1214
Closed

Tab container: support tab label with count #1195

sunnyyadav100 opened this issue Feb 8, 2020 · 3 comments · Fixed by #1214
Assignees

Comments

@sunnyyadav100
Copy link

sunnyyadav100 commented Feb 8, 2020

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Support of tab label with counter -

image

e.g.
https://sapui5.hana.ondemand.com/#/entity/sap.m.TabContainer/sample/sap.m.sample.TabContainerIcons (without tab image)

https://sap.github.io/fundamental-styles/components/tabs.html#tabs-with-counters

We have a requirement to show count on tab label as highlighted in above screenshot.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@fifoosid
Copy link
Contributor

Hi @sunnyyadav100,

Have you tried using the additionalText property?

@sunnyyadav100
Copy link
Author

sunnyyadav100 commented Feb 10, 2020

Yes, in that label appear as Tab label (23).
image

As per fiori guideline (I think), count should show above the label

@ilhan007
Copy link
Member

ilhan007 commented Feb 12, 2020

@sunnyyadav100 It turns out that "Standard" (the counter above the main text) and "Inline" (the counter next to the main text) modes exist:
https://experience.sap.com/fiori-design-web/icontabbar/

Although, the component is called ui5-tabcontainer we tried to also implement the design of sap.m.IconTabBar from openui5 as the controls are very similar and we don`t want to have two components. So, the ui5-tabcontainer is a little bit of mix between sap.m.TabContainer and sap.m.IconTabBar

We will think of something, so you can be able to display it both ways.

@ilhan007 ilhan007 self-assigned this Feb 13, 2020
ilhan007 added a commit that referenced this issue Feb 18, 2020
Add new property "tabLayout" to provide two types of alignment of the tab main and additional texts

Fixes: #1195
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants