fix(ui5-side-navigation): remove inappropriate exclamation mark usage

fixes: #10714
SAP · Feb 4, 2025 · 8624af0 · 8624af0
1 parent 0ebc0f4
commit 8624af0
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/packages/fiori/src/SideNavigation.ts b/packages/fiori/src/SideNavigation.ts
@@ -492,17 +492,19 @@ class SideNavigation extends UI5Element {
 
 			let itemDomRef;
 
-			if (isInstanceOfSideNavigationItemBase(item)) {
-				itemDomRef = item.getDomRef()!;
+			if (isInstanceOfSideNavigationItemBase(item) && item.getDomRef()) {
+				itemDomRef = item.getDomRef();
 			} else {
 				itemDomRef = item;
 			}
 
-			const { marginTop, marginBottom } = window.getComputedStyle(itemDomRef);
-			itemsHeight += itemDomRef.offsetHeight + parseFloat(marginTop) + parseFloat(marginBottom);
+			if (itemDomRef) {
+				const { marginTop, marginBottom } = window.getComputedStyle(itemDomRef);
+				itemsHeight += itemDomRef.offsetHeight + parseFloat(marginTop) + parseFloat(marginBottom);
 
-			if (itemsHeight > listHeight) {
-				item.classList.add("ui5-sn-item-hidden");
+				if (itemsHeight > listHeight) {
+					item.classList.add("ui5-sn-item-hidden");
+				}
 			}
 		});