fix: round values for element location for correct img cropping

SAP · Feb 17, 2020 · a5d9a9f · a5d9a9f
1 parent 6f5026f
commit a5d9a9f
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/src/image/localScreenshotProvider.js b/src/image/localScreenshotProvider.js
@@ -198,6 +198,7 @@ LocalScreenshotProvider.prototype._cropScreenshot = function(browserScreenshot,
             if (err) {
               deferCropScreenshot.reject(new Error('Cannot crop the screenshot: ' + err));
             } else {
+              that.logger.debug('View port in display pixels: width=' + data.width + ', height=' + data.height);
               // check if the element is completely outside the view port
               if (elementDimensions.left > data.width || elementDimensions.top > data.height ||
                 ((elementDimensions.width + elementDimensions.left) < 0) ||
@@ -263,6 +264,11 @@ LocalScreenshotProvider.prototype._crop = function(originalImageBuffer, cropConf
   var that = this;
   var deferCrop = webdriver.promise.defer();
 
+  // Round values for correct calculations in cropping
+  cropConfig.top = Math.round(cropConfig.top);
+  cropConfig.left = Math.round(cropConfig.left);
+  cropConfig.width = Math.round(cropConfig.width);
+  cropConfig.height = Math.round(cropConfig.height);
   that.logger.debug('Cropping the screenshot with parameters in display pixels: width=' + cropConfig.width +
     ', height=' + cropConfig.height + ', top=' + cropConfig.top + ', left=' + cropConfig.left);