Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INTERNAL] Deprecate UI5 Tooling v2 #829

Merged
merged 4 commits into from
May 29, 2023
Merged

[INTERNAL] Deprecate UI5 Tooling v2 #829

merged 4 commits into from
May 29, 2023

Conversation

d3xter666
Copy link
Contributor

@d3xter666 d3xter666 commented May 19, 2023 •
edited
Loading

@d3xter666 d3xter666 mentioned this pull request May 19, 2023
Merged
@d3xter666 d3xter666 requested a review from a team May 22, 2023 07:49
flovogt
flovogt requested changes May 22, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@d3xter666 @flovogt
Update README.md
9d6882a 
Co-authored-by: Florian Vogt <[email protected]>
This was referenced May 22, 2023
Merged
Merged
Merged
Merged
Merged
Merged
@d3xter666 d3xter666 requested a review from flovogt May 25, 2023 07:17
flovogt
flovogt reviewed May 25, 2023
View reviewed changes
README.md Show resolved Hide resolved
@d3xter666 d3xter666 requested a review from flovogt May 25, 2023 10:47
flovogt
flovogt requested changes May 25, 2023
View reviewed changes
Copy link
Member

@flovogt flovogt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-05-25 at 13 13 26

Do we really wanna display this like it is?
I would recommend to remove the note syntax at all and use a plain text

@d3xter666
Copy link
Contributor Author

d3xter666 commented May 25, 2023 •
edited
Loading

Screenshot 2023-05-25 at 13 13 26 Do we really wanna display this like it is? I would recommend to remove the note syntax at all and use a plain text

I tought we should somehow highlight those and this seems to be the only way to do it.
Otherwise these announcements would be lost winthin the rest of the text.

What do you think about this formatting:
Screenshot 2023-05-25 at 15 23 10

https://github.com/SAP/ui5-tooling/blob/d041a5acba16e8c6b7a49b45f2851d4d8a17c841/README.md#ui5-tooling

@d3xter666 d3xter666 requested review from flovogt and a team May 25, 2023 12:42
matz3
matz3 reviewed May 26, 2023
View reviewed changes
Copy link
Member

@matz3 matz3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

d3xter666 added a commit to SAP/ui5-project that referenced this pull request May 29, 2023
@d3xter666
[INTERNAL] Deprecate UI5 Tooling v2 (#613)
fdcc9e8 
JIRA: CPOUI5FOUNDATION-661

This Pull request complements with:
- SAP/ui5-tooling#829
- SAP/ui5-tooling#828
-  SAP/ui5-cli#631
- SAP/ui5-server#597
- SAP/ui5-builder#903
- SAP/ui5-fs#506
- SAP/ui5-logger#392
d3xter666 added a commit to SAP/ui5-logger that referenced this pull request May 29, 2023
@d3xter666
[INTERNAL] Deprecate UI5 Tooling v2 (#392)
4f2af25 
JIRA: CPOUI5FOUNDATION-661

This Pull request complements with:
- SAP/ui5-tooling#829
- SAP/ui5-tooling#828
-  SAP/ui5-cli#631
- SAP/ui5-project#613
- SAP/ui5-server#597
- SAP/ui5-builder#903
- SAP/ui5-fs#506
@d3xter666 d3xter666 merged commit 93aacdb into main May 29, 2023
@d3xter666 d3xter666 deleted the deprecate-v2 branch May 29, 2023 06:08
d3xter666 added a commit to SAP/ui5-fs that referenced this pull request May 29, 2023
@d3xter666
[INTERNAL] Deprecate UI5 Tooling v2 (#506)
1aee616 
JIRA: CPOUI5FOUNDATION-661

This Pull request complements with:
- SAP/ui5-tooling#829
- SAP/ui5-tooling#828
-  SAP/ui5-cli#631
- SAP/ui5-project#613
- SAP/ui5-server#597
- SAP/ui5-builder#903
- SAP/ui5-logger#392
d3xter666 added a commit to SAP/ui5-server that referenced this pull request May 29, 2023
@d3xter666
[INTERNAL] Deprecate UI5 Tooling v2 (#597)
7282eaa 
JIRA: CPOUI5FOUNDATION-661

This Pull request complements with:
- SAP/ui5-tooling#829
- SAP/ui5-tooling#828
-  SAP/ui5-cli#631
- SAP/ui5-project#613
- SAP/ui5-builder#903
- SAP/ui5-fs#506
- SAP/ui5-logger#392
d3xter666 added a commit to SAP/ui5-cli that referenced this pull request May 29, 2023
@d3xter666 @RandomByte
[INTERNAL] Deprecate UI5 Tooling v2 (#631)
16f7af1 
JIRA: CPOUI5FOUNDATION-661

This Pull request complements with:
- SAP/ui5-tooling#829
- SAP/ui5-tooling#828
- SAP/ui5-project#613
- SAP/ui5-server#597
- SAP/ui5-builder#903
- SAP/ui5-fs#506
- SAP/ui5-logger#392

---------

Co-authored-by: Merlin Beutlberger <[email protected]>
d3xter666 added a commit to SAP/ui5-builder that referenced this pull request May 30, 2023
@d3xter666
[INTERNAL] Deprecate UI5 Tooling v2 (#903)
34cb087 
JIRA: CPOUI5FOUNDATION-661

This Pull request complements with:
- SAP/ui5-tooling#829
- SAP/ui5-tooling#828
-  SAP/ui5-cli#631
- SAP/ui5-project#613
- SAP/ui5-server#597
- SAP/ui5-fs#506
- SAP/ui5-logger#392
flovogt added a commit that referenced this pull request Jun 6, 2023
@d3xter666 @RandomByte
@matz3 @flovogt @KlattG
[INTERNAL] Add deprecation message for UI5 Tooling v2 (#828)
b86c600 
JIRA: CPOUI5FOUNDATION-661

This Pull request complements with:
- #829
-  SAP/ui5-cli#631
- SAP/ui5-project#613
- SAP/ui5-server#597
- SAP/ui5-builder#903
- SAP/ui5-fs#506
- SAP/ui5-logger#392

---------

Co-authored-by: Merlin Beutlberger <[email protected]>
Co-authored-by: Matthias Oßwald <[email protected]>
Co-authored-by: Florian Vogt <[email protected]>
Co-authored-by: Günter Klatt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matz3 matz3 matz3 left review comments

@flovogt flovogt flovogt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@d3xter666 @matz3 @flovogt