-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot run ui5 with windows user that has accents in it. #469
Comments
Hi and thanks for reporting this issue! This seems to be caused by an explicitly documented limitation of the At least I was not aware of that limitation but it seems like we can just implement this normalization ourselves without this limitation. We'll look into it 👍 |
…aracters The `slash` module does not convert "extended-length" paths or paths which contain non-ASCII characters as documented in the modules README: https://github.com/sindresorhus/slash/blob/7a9158487d8046c13f2de1db7e3734d33bdbb1bd/readme.md#slash- Since in our case the resulting POSIX paths are only used in our virtual fs "@ui5/fs", these limitations are not relevent to us. Therefore we can simply replace any backslashes. Related to SAP/ui5-fs#294 Resolves SAP/ui5-tooling#469
…aracters The `slash` module does not convert "extended-length" paths or paths which contain non-ASCII characters as documented in the modules README: https://github.com/sindresorhus/slash/blob/7a9158487d8046c13f2de1db7e3734d33bdbb1bd/readme.md#slash- Since in our case the resulting POSIX paths are only used in our virtual fs "@ui5/fs", these limitations are not relevent to us. Therefore we can simply replace any backslashes. Related to SAP/ui5-fs#294 Resolves SAP/ui5-tooling#469
…aracters The `slash` module does not convert "extended-length" paths or paths which contain non-ASCII characters as documented in the modules README: https://github.com/sindresorhus/slash/blob/7a9158487d8046c13f2de1db7e3734d33bdbb1bd/readme.md#slash- Since in our case the resulting POSIX paths are only used in our virtual fs "@ui5/fs", these limitations are not relevent to us. Therefore we can simply replace any backslashes. Related to SAP/ui5-fs#294 Resolves SAP/ui5-tooling#469
…aracters The `slash` module does not convert "extended-length" paths or paths which contain non-ASCII characters as documented in the modules README: https://github.com/sindresorhus/slash/blob/7a9158487d8046c13f2de1db7e3734d33bdbb1bd/readme.md#slash- Since in our case the resulting POSIX paths are only used in our virtual fs "@ui5/fs", these limitations are not relevent to us. Therefore we can simply replace any backslashes. Related to SAP/ui5-fs#294 Resolves SAP/ui5-tooling#469
This should be fixed in @ui5/cli v2.7.1. Kindly re-test and confirm. Thanks! |
Expected Behavior
should be able to run ui5 serve (if i run the command with a user that has no accent in the name, it works fine)
Current Behavior
returns error:
Error Message:
Given file system path C:\Users\Bálint\.ui5\framework\packages@openui5\sap.tnt\1.84.0\src\sap\tnt is not based on source base path C:\Users\Bálint\.ui5\framework\packages@openui5\sap.tnt\1.84.0/src.
Steps to Reproduce the Issue
Context
ui5 --version
when using the CLI):2.6.6
12.14.1
6.13.4
windows
nothing
Log Output / Stack Trace
The text was updated successfully, but these errors were encountered: