Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INTERNAL] static translator and normalizer: added tests #75

Merged
merged 7 commits into from
Dec 17, 2018
Merged

[INTERNAL] static translator and normalizer: added tests #75

merged 7 commits into from
Dec 17, 2018

Conversation

romaniam
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Dec 11, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@romaniam romaniam changed the title [INTERNAL] static translator: added happy and sad path tests [INTERNAL] static translator and normalizer: added tests (happy and sad paths) Dec 11, 2018
@romaniam romaniam requested a review from RandomByte December 11, 2018 14:58
@romaniam romaniam changed the title [INTERNAL] static translator and normalizer: added tests (happy and sad paths) [INTERNAL] static translator and normalizer: added tests (happy and sad path) Dec 11, 2018
@romaniam romaniam changed the title [INTERNAL] static translator and normalizer: added tests (happy and sad path) [INTERNAL] static translator and normalizer: added tests Dec 12, 2018
@RandomByte RandomByte mentioned this pull request Dec 12, 2018
Closed
9 tasks
@coveralls
Copy link

Pull Request Test Coverage Report for Build 328

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+5.6%) to 79.322%
Totals Coverage Status
Change from base Build 318: 5.6%
Covered Lines: 318
Relevant Lines: 381
💛 - Coveralls

@SAP SAP deleted a comment from CLAassistant Dec 12, 2018
RandomByte
RandomByte requested changes Dec 12, 2018
View reviewed changes
Copy link
Member

@RandomByte RandomByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, just some small remarks

lib/translators/static.js Outdated Show resolved Hide resolved
@SAP SAP deleted a comment from coveralls Dec 12, 2018
@romaniam
[INTERNAL] static translator: stubbed fs access inside test. Added fs…
4302fc5 
… error message if no projectdep was found. Spelling fixes
RandomByte
RandomByte previously approved these changes Dec 14, 2018
View reviewed changes
matz3
matz3 reviewed Dec 17, 2018
View reviewed changes
lib/normalizer.js Outdated Show resolved Hide resolved
matz3
matz3 approved these changes Dec 17, 2018
View reviewed changes
Copy link
Member

@matz3 matz3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok from my side

@RandomByte RandomByte merged commit 595936d into master Dec 17, 2018
@RandomByte RandomByte deleted the static-translator-tests branch December 17, 2018 14:13
@RandomByte
Copy link
Member

COVERAGE INCREASED (+6.4%) TO 80.203%

Nice 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RandomByte RandomByte RandomByte left review comments

@matz3 matz3 matz3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@romaniam @CLAassistant @coveralls @RandomByte @matz3