Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTERNAL] Configuration docs: Add builder resource excludes #180

Merged
merged 4 commits into from
Jun 4, 2019

Conversation

RandomByte
Copy link
Member

@RandomByte RandomByte commented May 28, 2019

@coveralls
Copy link

coveralls commented May 28, 2019

Coverage Status

Coverage remained the same at 83.31% when pulling bae953e on exclude-config-docs into 0b7595b on master.

@RandomByte RandomByte changed the title [INTERNAL] Configuration docs: Add various resource excludes [INTERNAL] Configuration docs: Add builder resource excludes May 28, 2019
excludes:
- /resources/some/project/name/test_results/**
- /test-resources/**
- !/test-resources/some/project/name/demo-app/**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the syntax highlighting, this is not a valid string.
When parsing it, the JSON content is null. Quotes should be used.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍

@RandomByte RandomByte merged commit 5acfdef into master Jun 4, 2019
@RandomByte RandomByte deleted the exclude-config-docs branch June 4, 2019 15:24
@RandomByte RandomByte restored the exclude-config-docs branch June 4, 2019 15:27
@RandomByte RandomByte deleted the exclude-config-docs branch June 4, 2019 15:29
nlunets pushed a commit to nlunets/ui5-project that referenced this pull request Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants