Resolve naming conflict when the configured name is already used in code #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a configured "newVariableName" is already used in a sap.ui.define call but for a different module path, a new name is given to the replacer and extender by using the following method: * concatenate the last two parts within the module path, for example, "CoreElement" is used for module path "sap/ui/core/Element" * when the new name is still used in the sap.ui.define call, a number is added to the end of the name (starting from 0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a configured "newVariableName" is already used in a sap.ui.define
call but for a different module path, a new name is given to the
replacer and extender by using the following method:
"CoreElement" is used for module path "sap/ui/core/Element"
added to the end of the name (starting from 0)