[DEPENDENCY] Pin dir-glob to v2.0.0 #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dir-glob is a transitive dependency of globby ("dir-glob": "^2.0.0").
Some of our tests ("GLOB root directory" and "GLOB (normalized) root
directory (=> fs root)") are failing when using dir-glob v2.2.0.
Therefore pinning it to v2.0.0 for the time being.
This came up in our preflight tests which ignore the package-lock.json:
npm install --no-shrinkwrap --no-package-lock
Note: This is unrelated to #71
Tests were still failing after reverting that change.
Moreover, this is also reproducible on Git tag v0.2.0.
matz3
approved these changes
Jan 10, 2019
RandomByte
added a commit
that referenced
this pull request
Jan 30, 2019
Follow up of #73 To pin a transitive dependency when using Yarn, "resolutions" need to be used.
RandomByte
added a commit
that referenced
this pull request
Jan 31, 2019
Follow up of #73 To pin a transitive dependency when using Yarn, "resolutions" need to be used.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dir-glob is a transitive dependency of globby ("dir-glob": "^2.0.0").
Some of our tests ("GLOB root directory" and "GLOB (normalized) root
directory (=> fs root)") are failing when using dir-glob v2.2.0.
Therefore pinning it to v2.0.0 for the time being.
This came up in our preflight tests which ignore the package-lock.json:
npm install --no-shrinkwrap --no-package-lock
Note: This is unrelated to #71
Tests were still failing after reverting that change.
Moreover, this is also reproducible on Git tag v0.2.0.