[INTERNAL] resourceFactory: Add factory functions for Filter and Link readers, remove Transformer #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… readers Eventually remove them from AbstractReader to remove the circular dependency to sub-class.
RandomByte
added a commit
to SAP/ui5-project
that referenced
this pull request
Nov 10, 2022
By using new factory API from SAP/ui5-fs#438
RandomByte
changed the title
matz3
previously approved these changes
Nov 10, 2022
matz3
reviewed
Nov 10, 2022
…er reader tracing
We currently have no use case for this reader
RandomByte
force-pushed
the
move-readers-resourceFactory
branch
from
a83cd39 to
492051b
Compare
matz3
approved these changes
Nov 10, 2022
flovogt
reviewed
Nov 11, 2022
RandomByte
added a commit
to SAP/ui5-project
that referenced
this pull request
Nov 11, 2022
By using new factory API from SAP/ui5-fs#438
RandomByte
added a commit
to SAP/ui5-project
that referenced
this pull request
Nov 11, 2022
By using new factory API from SAP/ui5-fs#438
RandomByte
added a commit
to SAP/ui5-builder
that referenced
this pull request
Nov 17, 2022
…ilterReader Depends on SAP/ui5-project#514 Relates to SAP/ui5-fs#438
RandomByte
added a commit
to SAP/ui5-builder
that referenced
this pull request
Nov 18, 2022
…ilterReader Depends on SAP/ui5-project#514 Relates to SAP/ui5-fs#438
RandomByte
added a commit
to SAP/ui5-builder
that referenced
this pull request
Nov 29, 2022
…ilterReader Depends on SAP/ui5-project#514 Relates to SAP/ui5-fs#438
RandomByte
added a commit
to SAP/ui5-builder
that referenced
this pull request
Nov 29, 2022
…ilterReader Depends on SAP/ui5-project#514 Relates to SAP/ui5-fs#438
RandomByte
added a commit
that referenced
this pull request
Nov 30, 2022
They have been moved to resourceFactory in #438
RandomByte
added a commit
that referenced
this pull request
Nov 30, 2022
They have been moved to resourceFactory in #438 All known consumers have been updated accordingly.
RandomByte
added a commit
that referenced
this pull request
Nov 30, 2022
They have been moved to resourceFactory in #438 All known consumers have been updated accordingly.
RandomByte
added a commit
that referenced
this pull request
Nov 30, 2022
They have been moved to resourceFactory in #438 All known consumers have been updated accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eventually remove them from AbstractReader to remove the circular
dependency to sub-class.
We keep them for now to allow for a smooth release and consumption of the new API in ui5-project (via SAP/ui5-project#503). Afterwards we can remove the old API completely.