Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INTERNAL] resourceFactory: Mix-in virtual reader of dependencies #112

Merged
merged 1 commit into from
Mar 12, 2019
Merged

[INTERNAL] resourceFactory: Mix-in virtual reader of dependencies #112

merged 1 commit into from
Mar 12, 2019

Conversation

RandomByte
Copy link
Member

No description provided.

@RandomByte RandomByte mentioned this pull request Mar 7, 2019
Merged
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 85.159% when pulling 7cb9672 on resource-factory-create-collection-vir-readers into 3e9eef1 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 85.159% when pulling 7cb9672 on resource-factory-create-collection-vir-readers into 3e9eef1 on master.

matz3
matz3 reviewed Mar 11, 2019
View reviewed changes
Copy link
Member

@matz3 matz3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay from my side 👍 maybe @domianer wants to have a look

devtomtom
devtomtom approved these changes Mar 11, 2019
View reviewed changes
Copy link
Member

@devtomtom devtomtom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@RandomByte RandomByte merged commit 5dd313b into master Mar 12, 2019
@RandomByte RandomByte deleted the resource-factory-create-collection-vir-readers branch March 12, 2019 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matz3 matz3 matz3 left review comments

@devtomtom devtomtom devtomtom approved these changes

@domianer domianer Awaiting requested review from domianer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RandomByte @coveralls @matz3 @devtomtom