[INTERNAL] generateLibraryPreload: set requiresTopLevelScope correctly #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM but I'd like @codeworrior to also have a look into this. |
|
Sigh, double work. I was working on the same today morning (I had promised to do so, if you remember). I'll push another commit to this PR here. Luckily, overlap on test/* is, ehm, small :-) |
tobiasso85
force-pushed
the
requiresTopLevelScope-globals-fix
branch
from
21e6df5 to
7f64f15
Compare
Ensures that requiresTopLevelScope from .library is preferred and used when creating library preload. Builder.js: Use correct variable for ModuleInfo (exposedGlobals) to generate the correct globals assignment in library-preload.js
tobiasso85
force-pushed
the
requiresTopLevelScope-globals-fix
branch
from
ad9fbcb to
dbc69e6
Compare
matz3
approved these changes
Aug 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that
requiresTopLevelScopeoption inraw-moduleconfiguration from.libraryis preferred and usedwhen creating the library preload.
Builder.js: Use correct variable forModuleInfo(exposedGlobals) togenerate the correct globals assignment in
library-preload.js