[INTERNAL] Add tests #504
Merged
[INTERNAL] Add tests #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matz3
reviewed
Aug 20, 2020
Comment on lines
41
to
43
| const asyncTasks = Object.keys(themeLibraryBuilder.tasks).map((taskKey) => { | ||
| return themeLibraryBuilder.tasks[taskKey](); | ||
| }); |
There was a problem hiding this comment.
Whats the exact purpose of this? Just calling the function and expecting that no error is thrown?
There was a problem hiding this comment.
Well, better than no test. I've changed the assertion and just called build which also invokes the task functions.
fix naming in manifest.json file of library H
tobiasso85
force-pushed
the
add-test-coverage-improvement
branch
from
107ca33 to
b5777cc
Compare
matz3
approved these changes
Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests to increase coverage
Fix naming in manifest.json file of library H