Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INTERNAL] generateFlexChangesBundle: Follow-up adjustments #319

Merged
merged 2 commits into from
Aug 28, 2019
Merged

[INTERNAL] generateFlexChangesBundle: Follow-up adjustments #319

merged 2 commits into from
Aug 28, 2019

Conversation

matz3
Copy link
Member

@matz3 matz3 commented Aug 28, 2019

  • Ensure existence of sap.ui5 and sap.ui5/dependencies sections
  • Format modified manifest.json with tabs
  • Modify manifest json once after writing processed resources
  • Refactoring

Thank you for your contribution! 🙌

To get it merged faster, kindly review the checklist below:

Pull Request Checklist

@matz3
[INTERNAL] generateFlexChangesBundle: Follow-up adjustments
a495f54 
- Ensure existence of sap.ui5 and sap.ui5/dependencies sections
- Format modified manifest.json with tabs
- Modify manifest json once after writing processed resources
- Refactoring
@matz3 matz3 mentioned this pull request Aug 28, 2019
Merged
@coveralls
Copy link

coveralls commented Aug 28, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 86.315% when pulling a563824 on fl-dependency-follow-up into a8edff4 on master.

@codeworrior codeworrior self-requested a review August 28, 2019 07:23
codeworrior
codeworrior approved these changes Aug 28, 2019
View reviewed changes
Copy link
Member

@codeworrior codeworrior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, decrease in coverage is IMHO "verschmerzbar". In a later change, we might extract tests for the flex bundler task into a separate test module. At that time, another test for a manifest without sap.ui5/dependencies could be added

@matz3 matz3 merged commit 7bb71a2 into master Aug 28, 2019
@matz3 matz3 deleted the fl-dependency-follow-up branch August 28, 2019 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeworrior codeworrior codeworrior approved these changes

@RandomByte RandomByte Awaiting requested review from RandomByte

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matz3 @coveralls @codeworrior