[FIX] manifestCreator: Only consider component files called Component.js #273
Conversation
RandomByte
force-pushed
the
manifest-creator-component-js
branch
from
5beb444 to
8d82f22
Compare
In the past files called *Component.js where also considered as Components during manifest creation.
RandomByte
force-pushed
the
manifest-creator-component-js
branch
from
8d82f22 to
ba9da2e
Compare
lib/processors/manifestCreator.js
Outdated
| @@ -159,7 +159,7 @@ async function createManifest(libraryResource, libBundle, descriptorVersion, _in | |||
| function findComponentPaths() { | |||
| const result = []; | |||
| const prefix = libraryResource.getPath().slice(0, - ".library".length); | |||
| const components = libBundle.getResources(/(?:[^/]+\/)*Component\.js$/); | |||
| const components = libBundle.getResources(/^(?:[^/]*\/)*Component\.js$/); | |||
There was a problem hiding this comment.
The anchor was for sure missing, but the remainder of the pattern looks strange to me now. It accepts empty path segments (which shouldn't exist in the wild) and as the bundler is for libraries, I also don't know why a /Component.js should exist. It would have no namespace, which would be an error for a manifest.json.
There was a problem hiding this comment.
@codeworrior this code actually detect all components and will make the manifest creator complain if there is both a library and a Component.js.
Right now this create the following errors:
ERR! builder:processors:manifestCreator Package /resources/sap/fe/AppComponent.js contains both '*.library' and 'Component.js'. This is not supported by manifests, therefore the component won't be listed in the library's manifest.
/^(?:[^/]*\/)*Component\.js$/ matches things like
- Component.js
- /Component.js
- /toto/Component.js
- /toto/roro/Component.js
Which actually is an issue because we for instance ship components internally that can be reused as part of the library...
What would be the correct behavior here ?
There was a problem hiding this comment.
Actually after looking at this a bit more and discussing with @codeworrior we agreed that the right regexp would . be
^/(?:[^/]+\/)*Component\.js$ because it will find the right component files without matching an empty path in . the middle like the other one.
And since all resources path start with a slash that's coherent
In the past files called *Component.js where also considered as
Components during manifest creation.