[FIX] generateManifestBundle: Only glob files from project namespace #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manifestBundler can only include resources from paths that are based on the projects namespace (see regex in manifestBundler ZIP creation). For other paths the bundling fails because yazl can't add absolute paths. Also, only resources located in the projects "/resources" should be relevant for manifest bundling. The latter resovles UI5Lab/UI5Lab-library-simple#11 where with UI5 CLI v1.5.1 the only problem left is, that generateManifestBundle tries to bundle manifest.json resources found in the libraries /test-resources.
|
Shouldn't we still add some error handling within the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
manifestBundler can only include resources from paths that are based on the projects namespace (see regex in manifestBundler ZIP creation).
For other paths the bundling fails because yazl can't add absolute paths.
Also, only resources located in the projects "/resources" should be relevant for manifest bundling.
The latter resovles UI5Lab/UI5Lab-library-simple#11 where with UI5 CLI v1.5.1 the only problem left is, that generateManifestBundle tries to bundle manifest.json resources found in the libraries /test-resources.