[FIX] ApplicationFormatter: detect the namespace from component controller #243
Conversation
|
Maybe the fix is not the most optimal one, since it doesn’t use AST parsing to find the Component namespace and a regex instead but this definitely works (and is IMO as reliable as the AST one compared to the code and runtime effort being necessary to do AST parsing)! |
petermuessig
force-pushed
the
fix-appnamespace
branch
from
04e8ddb to
0199ea9
Compare
|
Enhanced the commit to read the pom.xml and be able to replace the Maven placeholders with the dedicated entries or properties from the pom.xml. |
|
This time I created a follow up commit which will be squashed before the merge later on... |
petermuessig
force-pushed
the
fix-appnamespace
branch
2 times, most recently
from
a30350b to
79a0499
Compare
|
Hmm, I am wondering why the build is failing! The JSDoc build works locally but somehow centrally it doesn't! I now squashed the change locally manually as this maybe affects the build... :-/ |
petermuessig
force-pushed
the
fix-appnamespace
branch
from
79a0499 to
d73bb11
Compare
When the manifest.json contains a Maven placeholder the namespace cannot be detected properly. With this extension the namespace can be resolved from the pom.xml from the pom entries or Maven properties.
petermuessig
force-pushed
the
fix-appnamespace
branch
from
d73bb11 to
68bfc58
Compare
|
Looks pretty good 👍 @tommyvinhlam to approve. |
|
Rebase required |
…rs (#243) When the manifest.json contains a Maven placeholder the namespace cannot be detected properly. With this extension the namespace can be resolved from the pom.xml from the pom entries or Maven properties.
When the manifest.json contains a Maven placeholder the namespace cannot
be detected properly. As a fallback the namespace will now be derived
from the component controller.
Thank you for your contribution! 🙌
To get it merged faster, kindly review the checklist below:
Pull Request Checklist