Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTERNAL] Travis: Activate Windows and Mac builds #100

Merged
merged 4 commits into from
Dec 18, 2018
Merged

Conversation

RandomByte
Copy link
Member

No description provided.

matz3
matz3 previously approved these changes Nov 12, 2018
@RandomByte
Copy link
Member Author

@codeworrior there seems to be an issue with the ComponentAnalyzer tests on Windows:
https://travis-ci.org/SAP/ui5-builder/jobs/454019734#L315

If you find the time, maybe you could have a look?

@tobiasso85
Copy link
Contributor

@codeworrior there seems to be an issue with the ComponentAnalyzer tests on Windows:
https://travis-ci.org/SAP/ui5-builder/jobs/454019734#L315

If you find the time, maybe you could have a look?

Fixed with
623c5ca

@coveralls
Copy link

coveralls commented Dec 17, 2018

Pull Request Test Coverage Report for Build 537

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 53.201%

Totals Coverage Status
Change from base Build 491: 0.0%
Covered Lines: 1473
Relevant Lines: 2506

💛 - Coveralls

Adjusts file paths to match the windows specific path separator
Compares json files in tests ignoring the newline character
Copy link
Member Author

@RandomByte RandomByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also ok from my side

@RandomByte RandomByte merged commit 5664e8c into master Dec 18, 2018
@RandomByte RandomByte deleted the travis-windows branch December 18, 2018 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants