Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot add custom tasks to type module #411

Closed
1 of 6 tasks
petermuessig opened this issue Nov 22, 2019 · 3 comments · Fixed by SAP/ui5-builder#375
Closed
1 of 6 tasks

Cannot add custom tasks to type module #411

petermuessig opened this issue Nov 22, 2019 · 3 comments · Fixed by SAP/ui5-builder#375
Labels
enhancement New feature or request module/ui5-builder Related to the UI5 Builder module

Comments

@petermuessig
Copy link

Expected Behavior

It should be possible to add a custom task to the build type module. Right now, you can only add custom tasks if standard tasks are added to a build type.

Current Behavior

The module build type has no standard tasks assigned and therefore it is not possible to add a custom task into the build chain.

Steps to reproduce the issue

Just use the build type module and try to assign a custom task

Context

  • UI5 Module Version (output of ui5 --version when using the CLI): any
  • Node.js Version: doesn't mind
  • npm Version: doesn't mind
  • OS/Platform: doesn't mind
  • Browser (if relevant): doesn't mind

Affected components (if known)
@petermuessig petermuessig changed the title Cannot add custom tasks to type: module Cannot add custom tasks to type module Nov 22, 2019
RandomByte referenced this issue in SAP/ui5-builder Nov 25, 2019
@RandomByte
[FEATURE] AbstractBuilder: Allow adding custom tasks for types that h…
a347947 
…ave no standard tasks

Types like "module" do not define any standard tasks. Hence custom tasks
can't reference anything in their "beforeTask" and "afterTask"
configuration.

With this change, the first custom task that a project of such type
defines can omit the before- or afterTask configuration and will be
automatically added as the first tasks.

Resolves https://github.com/SAP/ui5-builder/issues/368
RandomByte referenced this issue in SAP/ui5-builder Dec 17, 2019
@RandomByte
[FEATURE] AbstractBuilder: Allow adding custom tasks for types that h…
654450d 
…ave no standard tasks

Types like "module" do not define any standard tasks. Hence custom tasks
can't reference anything in their "beforeTask" and "afterTask"
configuration.

With this change, the first custom task that a project of such type
defines can omit the before- or afterTask configuration and will be
automatically added as the first tasks.

Resolves https://github.com/SAP/ui5-builder/issues/368
@RandomByte
Copy link
Member

Waiting for release

@RandomByte RandomByte reopened this Dec 17, 2019
@petermuessig
Copy link
Author

Cool! Great - this would enable a first shot usage on the UI5 Web Components project! :-) Thanks...

@RandomByte
Copy link
Member

Released with UI5 v1.13.0

@RandomByte RandomByte transferred this issue from SAP/ui5-builder Nov 20, 2020
@RandomByte RandomByte added enhancement New feature or request module/ui5-builder Related to the UI5 Builder module labels Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request module/ui5-builder Related to the UI5 Builder module
Projects
None yet
Milestone
No milestone
2 participants
@petermuessig @RandomByte