Fix issue in dependency handling, improve tests

lib/processors/resourceListCreator.js

@@ -146,10 +146,6 @@ class ResourceInfo {
 		}
 		return result;
 	}
-
-	isEmpty() {
-		return this.i18nLocale == null && this.i18nName == null && this.isDebug == false && this.theme == null && this.merged == false;
-	}
 }
 
 /**
@@ -412,7 +408,7 @@ class ResourceCollector {
 				resourceInfo.condRequired = resourceInfo.condRequired || new Set();
 				info.dependencies.forEach((dep) => {
 					if ( info.isConditionalDependency(dep) ) {
-						resourceInfo.condRequired.push(dep);
+						resourceInfo.condRequired.add(dep);
 					} else if ( !info.isImplicitDependency(dep) ) {
 						resourceInfo.required.add(dep);
 					}

lib/types/library/LibraryBuilder.js

@@ -1,22 +1,5 @@
 const AbstractBuilder = require("../AbstractBuilder");
-const tasks = { // can't require index.js due to circular dependency
-	generateComponentPreload: require("../../tasks/bundlers/generateComponentPreload"),
-	generateFlexChangesBundle: require("../../tasks/bundlers/generateFlexChangesBundle"),
-	generateBundle: require("../../tasks/bundlers/generateBundle"),
-	generateLibraryPreload: require("../../tasks/bundlers/generateLibraryPreload"),
-	generateManifestBundle: require("../../tasks/bundlers/generateManifestBundle"),
-	generateStandaloneAppBundle: require("../../tasks/bundlers/generateStandaloneAppBundle"),
-	escapeNonAsciiCharacters: require("../../tasks/escapeNonAsciiCharacters"),
-	buildThemes: require("../../tasks/buildThemes"),
-	createDebugFiles: require("../../tasks/createDebugFiles"),
-	generateJsdoc: require("../../tasks/jsdoc/generateJsdoc"),
-	executeJsdocSdkTransformation: require("../../tasks/jsdoc/executeJsdocSdkTransformation"),
-	generateLibraryManifest: require("../../tasks/generateLibraryManifest"),
-	generateVersionInfo: require("../../tasks/generateVersionInfo"),
-	replaceCopyright: require("../../tasks/replaceCopyright"),
-	replaceVersion: require("../../tasks/replaceVersion"),
-	uglify: require("../../tasks/uglify")
-};
+const {getTask} = require("../../tasks/taskRepository");
 
 class LibraryBuilder extends AbstractBuilder {
 	addStandardTasks({resourceCollections, project, log, buildContext}) {
@@ -194,6 +177,15 @@ class LibraryBuilder extends AbstractBuilder {
 				}
 			});
 		});
+
+		this.addTask("generateResourcesJson", () => {
+			return getTask("generateResourcesJson").task({
+				workspace: resourceCollections.workspace,
+				dependencies: resourceCollections.dependencies,
+				options: {
+				}
+			});
+		});
 	}
 }
 

test/expected/build/library.n/dest/resources/library/n/Button-dbg.js

@@ -14,7 +14,7 @@ sap.ui.define([
 ) {
 	"use strict";
 
-	return Control.extend("library.n.Button", { 
+	return Control.extend("library.n.Button", {
 		metadata : {
 			library : "library.n",
 			properties : {
@@ -44,6 +44,13 @@ sap.ui.define([
 				oRm.close("span");
 				oRm.close("button");
 			}
+		},
+		helper: function(sCalendarType) {
+			var sCalendar = "sap/ui/core/date/" + sCalendarType;
+			sap.ui.require(["sap/ui/core/format/DateFormat", sCalendar], function(DateFormat, Calendar) {
+				DateFormat.getInstance();
+				new Calendar();
+			});
 		}
 	});
 

test/expected/build/library.n/dest/resources/library/n/resources.json

@@ -11,15 +11,23 @@
 			"required": [
 				"library/n/library.js",
 				"sap/ui/core/Control.js"
-			]
+			],
+			"condRequired": [
+				"sap/ui/core/format/DateFormat.js"
+			],
+			"dynRequired": true
 		},
 		{
 			"name": "Button.js",
 			"module": "library/n/Button.js",
 			"required": [
 				"library/n/library.js",
 				"sap/ui/core/Control.js"
-			]
+			],
+			"condRequired": [
+				"sap/ui/core/format/DateFormat.js"
+			],
+			"dynRequired": true
 		},
 		{
 			"name": "changeHandler/SplitButton-dbg.js",

test/fixtures/library.n/src/library/n/Button.js

@@ -12,7 +12,7 @@ sap.ui.define([
 ) {
 	"use strict";
 
-	return Control.extend("library.n.Button", { 
+	return Control.extend("library.n.Button", {
 		metadata : {
 			library : "library.n",
 			properties : {
@@ -42,6 +42,13 @@ sap.ui.define([
 				oRm.close("span");
 				oRm.close("button");
 			}
+		},
+		helper: function(sCalendarType) {
+			var sCalendar = "sap/ui/core/date/" + sCalendarType;
+			sap.ui.require(["sap/ui/core/format/DateFormat", sCalendar], function(DateFormat, Calendar) {
+				DateFormat.getInstance();
+				new Calendar();
+			});
 		}
 	});