[FIX] Use consistent RegExp to detect copyright comments (#275)

Bundle Builder and AutoSplitter now use the same RegExp to detect copyrights that the uglifier task uses.

Fixes https://github.com/SAP/ui5-builder/issues/257 .

lib/lbt/bundle/AutoSplitter.js

@@ -6,7 +6,7 @@ const ModuleName = require("../utils/ModuleName");
 const {SectionType} = require("./BundleDefinition");
 const log = require("@ui5/logger").getLogger("lbt:bundle:AutoSplitter");
 
-const copyrightCommentsPattern = /copyright|\(c\)|released under|license|\u00a9/i;
+const copyrightCommentsPattern = /copyright|\(c\)(?:[0-9]+|\s+[0-9A-za-z])|released under|license|\u00a9/i;
 const xmlHtmlPrePattern = /<(?:\w+:)?pre>/;
 
 /**

lib/lbt/bundle/Builder.js

@@ -19,7 +19,7 @@ const {SectionType} = require("./BundleDefinition");
 const BundleWriter = require("./BundleWriter");
 const log = require("@ui5/logger").getLogger("lbt:bundle:Builder");
 
-const copyrightCommentsPattern = /copyright|\(c\)|released under|license|\u00a9/i;
+const copyrightCommentsPattern = /copyright|\(c\)(?:[0-9]+|\s+[0-9A-za-z])|released under|license|\u00a9/i;
 const xmlHtmlPrePattern = /<(?:\w+:)?pre>/;
 
 const strReplacements = {

test/expected/build/sap.ui.core/preload/resources/sap/ui/core/some.js

@@ -1,4 +1,14 @@
 /*!
  * ${copyright}
  */
-console.log('HelloWorld');
+console.log('HelloWorld');
+
+/*
+ * function add(c) - this is still not implemented.
+ * @private
+ * @param {Component} c
+ * @name add
+ * This comment should be removed in the preload bundle although it contains the magic
+ * sequence "opening parenthesis - letter c - closing parenthesis" which usually indicates
+ * a  c o p y r i g h t  comment.
+ */

test/fixtures/sap.ui.core/main/src/sap/ui/core/some.js

@@ -1,4 +1,14 @@
 /*!
  * ${copyright}
  */
-console.log('HelloWorld');
+console.log('HelloWorld');
+
+/*
+ * function add(c) - this is still not implemented.
+ * @private
+ * @param {Component} c
+ * @name add
+ * This comment should be removed in the preload bundle although it contains the magic
+ * sequence "opening parenthesis - letter c - closing parenthesis" which usually indicates
+ * a  c o p y r i g h t  comment.
+ */