-
Notifications
You must be signed in to change notification settings - Fork 23
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Switch XML minifier from pretty-data to minify-xml
All in all pretty-data is a pretty bad (phun intended) XML minifier. It does for instance not minify tag contents, nor it optimizes anything else than removing comments and whitespaces between tags. Tags like: <Tag attributeA = "..." attributeB = "..." /> Will not get reduced in size. Switched to minify-xml (a package which I specifically created for this patch, to do a better job at minfying) on the other hands removes comments and whitespaces between tags, as well as collapses whitespaces in tags and removes unused namespaces from views. These are all pretty common use-cases for UI5 xml views, thus I clearly think it's the better option compared to pretty-data. Also this change removes the strange assumption that pretty-data (or now minify-xml) would modify any tag content (like pre tags), which both libraries clearly don't do. Fixed typo in test (autpSplitter).
- Loading branch information
Showing
9 changed files
with
117 additions
and
142 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.