Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: code improvements based on SonarCloud findings for the Api-Credential Resources #950

Merged
merged 8 commits into from
Nov 20, 2024

Conversation

diya-dhan
Copy link
Contributor

Purpose

A few code changes have been introduced to optimise the code. These are based on suggestions given by the SonarCloud checks.

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Test the code via automated test
go test ./...

What to Check

Verify that the following are valid:

  • Automated tests are executed successfully

Other Information

Links to the issues reported by SonarCloud:

Checklist for reviewer

The following organizational tasks must be completed before merging this PR:

  • The PR is assigned to the Terraform project and a status is set (typically "in review").
  • The PR has the matching labels assigned to it.
  • The PR has a milestone assigned to it.
  • If the PR closes an issue, the issue is referenced.
  • Possible follow-up items are created and linked.

@diya-dhan diya-dhan changed the title feature: code improvements based on SonarCloud findings for the Api-Credential Resources feat: code improvements based on SonarCloud findings for the Api-Credential Resources Nov 11, 2024
@lechnerc77 lechnerc77 enabled auto-merge (squash) November 11, 2024 12:37
@lechnerc77 lechnerc77 added the refactoring Refactoring of code label Nov 11, 2024
@lechnerc77 lechnerc77 added this to the 1.9.0 milestone Nov 11, 2024
@diya-dhan diya-dhan linked an issue Nov 11, 2024 that may be closed by this pull request
@lechnerc77 lechnerc77 merged commit 074463e into main Nov 20, 2024
14 of 15 checks passed
@lechnerc77 lechnerc77 deleted the issue_948 branch November 20, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactoring of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Improve Code Quality based on Sonar Cloud Findings
3 participants