Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default behaviour so that all code files are considered #336

Closed
copernico opened this issue Oct 14, 2022 · 1 comment
Closed

Change default behaviour so that all code files are considered #336

copernico opened this issue Oct 14, 2022 · 1 comment

Comments

@copernico
Copy link
Contributor

copernico commented Oct 14, 2022

Some projects, such as Ambari, use a variety of languages so it is cumbersome to have to specify which extensions to consider.

The default behaviour could be changed so that any file from a known code extension is considered (we could take a reasonable list of such extensions as a starting point, e.g. java, c, cpp, h, js, jsp, py, go, rb).

example: CVE-2020-1936

Ambari is developed in java + javascript + python (+a few others). The fix commit is easily identified by specifying --filter-languages=js, but it is discarded otherwise.

copernico pushed a commit that referenced this issue Nov 3, 2022
- Implemented twin commits, closes #147 
- Using basemodel again (pydantic)
- Fixed the logger, improved log aesthetics and readability
- github and jira issues are collected using their respective APIs (GITHUB token required via .env file)
- Better word extraction and filtering based on tests conducted on the small dataset.
- Report handlers now create nested folders
- updated to python 3.10
- skip GitHub when fetching references
- refactored git and raw_commit modules: all commit IDs, timestamp, parent, message and changed files are
collected with a single call to git executable
- refactored logging

- Fixes:
#339  
#341  
#334  
#331  
#326 
#336
@sacca97
Copy link
Collaborator

sacca97 commented Nov 4, 2022

Closed by #342

@sacca97 sacca97 closed this as completed Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants