Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: upgrade to storybook@6 #1088

Merged
merged 11 commits into from
Jun 9, 2020
Merged

docs: upgrade to storybook@6 #1088

merged 11 commits into from
Jun 9, 2020

Conversation

jbadan
Copy link
Contributor

@jbadan jbadan commented Jun 5, 2020

Description

  • upgrade storybook 📖
  • add knobs to all stories 🚪
  • rework short-id mock to improve snapshots (no more having to update multiple for one small change) 🔢
  • Stories now all have toolbars 🔨
  • addonA11y renabled
  • storyshots work with hooks now 🐟

fixes #1051

@jbadan jbadan requested a review from a team June 5, 2020 19:38
@netlify
Copy link

netlify bot commented Jun 5, 2020

Deploy preview for fundamental-react ready!

Built with commit c8a756f

https://deploy-preview-1088--fundamental-react.netlify.app

@@ -44,12 +44,10 @@ export default {
export const ${componentName} = () => {
Copy link
Contributor

@skvale skvale Jun 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 27 says

        // TODO: reenable storyshots for examples using hooks in storybook@6
       // https://github.com/storybookjs/storybook/releases/tag/v6.0.0-alpha.43

Can we do that now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dialog and Calendar are still having problems so I've left them in the ignored bucket for now and will do a separate followup

@jbadan jbadan requested a review from a team June 9, 2020 13:46
Copy link
Contributor

@skvale skvale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbadan jbadan merged commit 3196af5 into master Jun 9, 2020
@jbadan jbadan deleted the storybook6 branch June 9, 2020 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: upgrade to storybook 0.6.0 (when released)
2 participants