-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: upgrade to storybook@6 #1088
Conversation
Deploy preview for fundamental-react ready! Built with commit c8a756f |
@@ -44,12 +44,10 @@ export default { | |||
export const ${componentName} = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line 27 says
// TODO: reenable storyshots for examples using hooks in storybook@6 // https://github.com/storybookjs/storybook/releases/tag/v6.0.0-alpha.43
Can we do that now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dialog and Calendar are still having problems so I've left them in the ignored bucket for now and will do a separate followup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
fixes #1051