Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(platform): select - fix CVA behavior and remove extra methods #7338

Merged
merged 1 commit into from
Dec 16, 2021

Conversation

dmitry-stepanenko
Copy link
Contributor

@dmitry-stepanenko dmitry-stepanenko commented Dec 8, 2021

Related Issue(s)

related to #6866

Description

Added ngx-cva-test-suite for platform-select component. It was required to make some minor changes in order to fulfill requirements of standard behavior for CVA. Also made some cleanup to get rid of unnecessary methods.

Breaking changes:

  • source has been removed from FdpSelectionChangeEvent, FdpSelectionChangeEvent itself is now deprecated
  • valueChange output has been removed as it completely duplicates selectionChange output

Screenshots

Before:

After:

Please check whether the PR fulfills the following requirements

During Implementation
  1. Visual Testing:
  • [n/a] visual misalignments/updates
  • [n/a] check Light/Dark/HCB/HCW themes
  • [n/a] RTL/LTR - proper rendering and labeling
  • [n/a] responsiveness(resize)
  • [n/a] Content Density (Cozy/Compact/(Condensed))
  • States - hover/disabled/focused/active/on click/selected/selected hover/press state
  • Interaction/Animation - open/close, expand/collapse, add/remove, check/uncheck
  • Mouse vs. Keyboard support
  • [n/a] Text Truncation
  1. API and functional correctness
  • check for console logs (warnings, errors)
  • [n/a] API boundary values
  • [n/a] different combinations of components - free style
  • [n/a] change the API values during testing
  1. Documentation and Example validations
  • [n/a] missing API documentation or it is not understandable
  • [n/a] poor examples
  • Stackblitz works for all examples
  1. Accessibility testing
  2. Browser Testing - Edge, Safari, Chrome, Firefox
PR Quality

@netlify
Copy link

netlify bot commented Dec 8, 2021

✔️ Deploy Preview for fundamental-ngx ready!

🔨 Explore the source changes: 6e35222

🔍 Inspect the deploy log: https://app.netlify.com/sites/fundamental-ngx/deploys/61b1c6d65547db00085bf869

😎 Browse the preview: https://deploy-preview-7338--fundamental-ngx.netlify.app

@dmitry-stepanenko dmitry-stepanenko added the ready for qa Testing should be started for the PR label Dec 10, 2021
@github-actions
Copy link

This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days

@github-actions github-actions bot added the stale label Dec 13, 2021
@Seamoo13 Seamoo13 added QA Approved and removed ready for qa Testing should be started for the PR labels Dec 13, 2021
@Betrozov Betrozov merged commit d9e2642 into main Dec 16, 2021
@Betrozov Betrozov deleted the ds/cva-tests-platform-select branch December 16, 2021 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants