fix(platform): select - fix CVA behavior and remove extra methods #7338
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
related to #6866
Description
Added
ngx-cva-test-suite
forplatform-select
component. It was required to make some minor changes in order to fulfill requirements of standard behavior for CVA. Also made some cleanup to get rid of unnecessary methods.Breaking changes:
source
has been removed fromFdpSelectionChangeEvent
,FdpSelectionChangeEvent
itself is now deprecatedvalueChange
output has been removed as it completely duplicatesselectionChange
outputScreenshots
Before:
After:
Please check whether the PR fulfills the following requirements
During Implementation
PR Quality
https://github.com/SAP/fundamental-ngx/blob/main/CONTRIBUTING.md
https://github.com/SAP/fundamental-ngx/wiki/PR-Review-Checklist
README.md