Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer pragmas to pseudo comments #421

Closed
lucasborin opened this issue Jun 22, 2021 · 1 comment · Fixed by #446
Closed

Prefer pragmas to pseudo comments #421

lucasborin opened this issue Jun 22, 2021 · 1 comment · Fixed by #446
Assignees
@lucasborin
Labels
new check New check

Comments

@lucasborin
Copy link
Member

Use program ABAP_SLIN_PRAGMAS or table SLIN_DESC to find the mapping between obsolete pseudo comments and the pragmas that have replaced them.

From: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-pragmas-to-pseudo-comments

A new check could scan if the pseudo comments available in the SLIN_DESC table are in use and suggest the change
by the pragma instead.
@lucasborin lucasborin added the new check New check label Jun 22, 2021
@lucasborin lucasborin self-assigned this Aug 19, 2021
@lucasborin
Copy link
Member Author

More references https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abenpseudo_comment_slin.htm

@lucasborin lucasborin linked a pull request Aug 20, 2021 that will close this issue
Prefer Pragmas to Pseudo Comments #446
Merged
@lucasborin lucasborin mentioned this issue Nov 1, 2021
Merged
lucasborin added a commit that referenced this issue Nov 1, 2021
@lucasborin
1.16.0 (#440)
a86f9d1 
2021-11-01 v.1.16.0
------------------
* Prefer New: Dynamic Call with Parameters (#502)
* DB Access in UT: Global Inheritance (#500)
* DB Access in UT: Local Inheritance (#498)
* Skip 'Prefer RETURNING to EXPORTING' when both exist (#490)
* Pseudo Comment Usage: Multiple Inline Entries (#494)
* Prefer Pragmas to Pseudo Comments: Multiple Pseudo Comments (#489)
* Y_CHECK_MESSAGE_EASY_TO_FIND dump (#492)
* Chain Declaration for Complex Structures (#488)
* Empty Catch Alternative Pseudo Comment (#337)
+ Alternative Pseudo Comment (#486)
* line_exists does not support the operator IN (#484)
* Empty Catch: Test Double Framework (#483)
* Y_CHECK_FORM: Screen Events (#454)
* Magic Number: CASE SY-TABIX and CO NUMBERS (#480)
* Magic Number: Leading Zeros (#479)
* Prefer New to Create Object: Dynamic Type (#469)
* Magic Number: Table Index (#468)
* Use native *_wa variables (#474)
* Refactoring (#436,#452,#458)
* Cannot run unit tests on 752 (#461)
* Profiles: Allow Exemptions (#447)
* BAdI example class vs Percentage Comment (#443)
* Unit-Test Assert Validator (#450)
+ Prefer Pragmas to Pseudo Comments (#421)
+ COLLECT restriction (#441)
* RAP needs CREATE OBJECT ... FOR TESTING (#444)
* Filter functional operands in "Unit Test Assert" check (#460)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucasborin lucasborin

Labels
new check New check
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prefer Pragmas to Pseudo Comments SAP/code-pal-for-abap
1 participant
@lucasborin