Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ServiceBindingMapper for IAS configuration without domains #1153

Merged
merged 3 commits into from
Apr 14, 2023

Conversation

finkmanAtSap
Copy link
Contributor

For backward compatibility, it also accepts single String values instead of String arrays for 'domains'. Single String values may also be provided via key 'domain'.

…s no domains in credentials.

For backward compatibility, it also accepts single String values instead of String arrays for 'domains'.
Single String values may also be provided via key 'domain'.
@finkmanAtSap finkmanAtSap requested a review from liga-oz April 13, 2023 12:41
Copy link
Contributor

@liga-oz liga-oz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All in al looks very good, but the cast from string to string list for domains is not semantically correct, because domains shouldn't ever come from IAS binding as a string, therefore I would say you can remove that casting part.

Copy link
Contributor

@liga-oz liga-oz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@finkmanAtSap
Copy link
Contributor Author

All in al looks very good, but the cast from string to string list for domains is not semantically correct, because domains shouldn't ever come from IAS binding as a string, therefore I would say you can remove that casting part.

Thanks for hint :) Makes the code much cleaner <3

@finkmanAtSap finkmanAtSap merged commit a91328e into main-2.x Apr 14, 2023
@finkmanAtSap finkmanAtSap deleted the main-2.x-ias-missing-domains-fix branch April 14, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants