Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add nodenext option #5177

Merged
merged 4 commits into from
Nov 14, 2024
Merged

fix: Add nodenext option #5177

merged 4 commits into from
Nov 14, 2024

Conversation

deekshas8
Copy link
Contributor

@deekshas8 deekshas8 commented Nov 14, 2024

Copy link
Contributor

@ZhongpinWang ZhongpinWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deekshas8
Copy link
Contributor Author

[q] Just curious, what about other module kinds like es2022?

moduleResolution nodenext requires that module is also nodenext.
We can add it as an option, but it doesn't fix this specific issue.

@deekshas8 deekshas8 merged commit 745766e into main Nov 14, 2024
16 checks passed
@deekshas8 deekshas8 deleted the esm-cjs branch November 14, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants