Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mtls exports #60

Merged
merged 5 commits into from
Jan 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
},
"devDependencies": {
"@types/jest": "^26.0.14",
"@types/node": "^14.6.2",
"@types/node": "^14.18.36",
"@typescript-eslint/eslint-plugin": "^4.4.0",
"@typescript-eslint/parser": "^4.4.0",
"eslint": "^7.10.0",
Expand Down
8 changes: 7 additions & 1 deletion src/index.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,16 @@
import AlertNotificationClient, { AlertNotificationConfiguration } from './client';

export {
DestinationConfiguration,
CredentialsForDestinationService
} from './utils/destination-configuration';

export {
Credentials,
OAuthConfig,
BasicAuthentication,
OAuthAuthentication
OAuthAuthentication,
CertificateAuthentication
} from './authentication';

export * as RegionUtils from './utils/region';
Expand Down
6 changes: 3 additions & 3 deletions src/utils/destination-configuration.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { BasicAuthentication, OAuthAuthentication } from '../authentication';
import { KeyStore, KeystoreFormat } from './key-store';
import { toPem } from 'jks-js';

export interface Credentials {
export interface CredentialsForDestinationService {
/**
* Username
*/
Expand Down Expand Up @@ -41,10 +41,10 @@ export class DestinationConfiguration {
/**
* Creates an instance of DestinationServiceConfiguration.
*
* @param {Credentials} config - contains username, password, destinationName, destinationUrl and oAuthTokenUrl. All
* @param {CredentialsForDestinationService} config - contains username, password, destinationName, destinationUrl and oAuthTokenUrl. All
* of them must be provided else Error will be thrown.
*/
constructor(config: Credentials) {
constructor(config: CredentialsForDestinationService) {
if (!config) {
throw new Error('Configuration cannot be null, undefined or empty object');
}
Expand Down